Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Removing Android dependency from forgot password presenter

See original GitHub issue

Actual Behaviour

According to MVP pattern, the presenter must not have any android dependency as it makes it difficult to test the presenter later on separately.

Here we can see that there is a dependency of android.color in the Presenter. https://github.com/fossasia/susi_android/blob/development/app/src/main/java/org/fossasia/susi/ai/forgotpassword/ForgotPasswordPresenter.kt#L3

Expected Behaviour

Remove this to follow proper MVP pattern.

Would you like to work on the issue? yes

Issue Analytics

State:
Created 6 years ago
Comments:6 (4 by maintainers)

Top GitHub Comments

1reaction

batbrain7commented, Jun 3, 2018

@anandkumarkparmar okay go ahead

0reactions

batbrain7commented, Jun 4, 2018

or make your own branch and a send a PR deleting the forgotpassword activity along with the package

Top Results From Across the Web

Remove Dependency Android Resolver (Android Advertising ...

My question here is: Is there a way to remove a single dependency from Android Resolver dependencies generated by the firebase-unity ...

Security - Android Developers

Your DPC can reset a user's password by authorizing the change with a preregistered, secure token. Device owners and profile owners can call ......

Manual dependency injection - Android Developers

Basics of manual dependency injection; Managing dependencies with a container; Managing dependencies in application flows; Conclusion.

AccountManager - Android Developers

Action sent as a broadcast Intent by the AccountsService when accounts are added, accounts are removed, or an account's credentials (saved password, ...

Device administration overview - Android Developers

To uninstall an existing device admin app, users need to first unregister the ... Note that the Device Administration API currently only supports...