Missings ACEs

When working on a lab I noticed bloodhound-python is missing ACEs. To compare, I used bloodhound ingestor from the official bloodhound repository. The 2 dumps were performed at the same time.

import json
with open("computers.json") as f:
     wrong = json.load(f)

with open("20210307143122_computers.json") as f:
     correct = json.load(f)

wrong['computers'][1]['Properties']['name']
'TEST.SUB.CORP.LOCAL'

correct['computers'][1]['Properties']['name']
'TEST.SUB.CORP.LOCAL'

len(wrong['computers'][1]['Aces'])
7
len(correct['computers'][1]['Aces'])
9

In this specific case, bloodhound is missing a critical ACE for domain user with Extended Rights :

        {
          "PrincipalSID": "S-1-5-21-1559563558-6653093943-1360247436-1103",
          "PrincipalType": "User",
          "RightName": "ExtendedRight",
          "AceType": "All",
          "IsInherited": false
        }

When running bloodhound-python I got no particular error except SID resolution (global catalog server not found) and nothing related to this user.

[tiyeuse]

In my case these modifications did the job, I could the see the previous missing permission. If everything else works (including computers with LAPS) that could be cool. Thanks 👍

[jarilaos]

I think the issue is in this line. Just adding computer maybe fix your problem but if the computer has no laps you will see this in GUI. In order to avoid that message it is recommended to check laps first like this, as sharphound does too. Keep in mind that there is another check for computer extendedright here that could be reported as an unexploitable ace.

I added changes to #60 fixing this issue.