Changes appearing immediately after switching layouts

When switching between layouts, the layout sometimes immediately appears modified, even though the user didn’t change anything. If you look at the json before/after, sometimes the panel configs that change are actually from panels that aren’t present in the layout — this indicates a stale reference to old config being saved under the new layout.

I thought I already fixed this issue in #1425, so not sure if it regressed or just wasn’t totally fixed. The logic for savedDefaultConfig.current here is supposed to prevent saving data from an old layout after switching.

https://github.com/foxglove/studio/blob/62d8b42e5817e00660015a5baf3144dc2d5f8d7f/packages/studio-base/src/components/Panel.tsx#L189-L198

[defunctzombie]

From our chat - it seems that the issue here is synthetic and would not occur the same way through user interaction. The “inject edit” adds a panel to the layout but fails to add the default config. A user that is working with the app on two computers and adding a layout would not produce the same result since the app will set the default config when the panel is added to the layout.

I’m gonna close this issue since through user interaction this same flow would not occur. If we do find other instances of changes appearing in unexpected ways (or via remote interaction) we should open new issues with reproduction for those.

[jtbandes]

If the server version changes the base on a sync I would expect that to be shown as changes compared to the working copy?

If you’ve never made changes to the layout locally or even clicked on it, someone else changing it on the server shouldn’t result in a modified dot on your machine. Notice in my video the dot doesn’t appear upon sync, but only when loading the layout.

The dot being visible is just “working copy != undefined”. An unmodified layout doesn’t have a working copy, only the baseline