Attachments: Storage paths and UI improvements

Right now when attaching documents, they all end up in the same directory. Over time this could potentially be an issue if the file count is big.

1. Storage paths I believe it would be a great idea to have some sort of weighted tree as well as a top-level placing them in context from where they where uploaded, i.e.

    files/
        Buying / 
            Supplier Quotation / 
                YYMM/
                    Supplier-XY-quote-170319-A01.pdf

1. UI improvements Once a file is attached to a document, it’s shown in the side-bar. Here it looses a bit it’s meta data as we can’t see it’s public or private, edit that setting, it’s full filename and so on. The suggestion solution is to add the feature of viewing the attachment inline using an expandable “side pane”. I believe this would improve a daily workflow in many ways, like
   • being able to quickly view (side-by-side) the contents of an attachment while entering it’s data to the form (i.e. a supplier pdf invoice where supplier-invoice data needs to be keyed in)
   • once expanded, we have space to show the full file properties such as date, sharing status, download button, etc.

Related, I believe certain attached documents like a receipt or a scanned “paper-copy” of an official invoice shouldn’t be possible to remove once the invoice has been submitted.

[barredterra]

From a programming perspective, a preview is really simple. I just created this proof of concept:

Instead of

<div class="col-md-2">
    <!-- Sidebar -->
</div>
<div class="col-md-10">
    <!-- Document -->
    <!-- Comments -->
</div>

we’ll have

<div class="col-md-2">
    <!-- Sidebar -->
</div>
<div class="col-md-5">
    <!-- Preview -->
    <embed src="https://my.erpnext.com/private/files/SINV-0001.pdf">
</div>
<div class="col-md-5">
    <!-- Document -->
</div>
<div class="col-md-2"/>
<div class="col-md-5">
    <!-- Comments -->
</div>

and some CSS to adjust the size of the preview.

To make it more comfortable, the preview could be switched on or off by an Eye-Icon on the attached document.

[chdecultot]

In terms of UX, being able to change the name of the file directly in ERPNext would be a nice feature.