HTML files for custom app Print Formats
See original GitHub issueDescription of the issue
I’m working for a company that has created multiple apps for internal use. We have been creating custom Print Formats for native DocTypes in the old fashion: With the html code in the .json. But we think that it would be nice to have those Print Formats as .html files, as it can be done when the Print Format is for a DocType native to the app that has the Print Format.
Context information (for bug reports)
The bug has no output. The behaviour is just not desired. The Print Format will not use the html file and just use the html field.
Steps to reproduce the issue
- Create a custom app
- Add to your app a Print Format for Sales Invoice with Standard in Yes, Print format type: Jinja, Custom format checked, and your app module.
- Create an html file with the scrubed name of the Print Format in the print_format folder of your module.
- Try to execute the Print Format
Observed result
The Print Format does not render the HTML file.
Expected result
It should render the HTML file as it does when your Print Format references a custom DocType from your app.
Additional information
The problem is in the printview.py
file, in the line 254. I will create a PR with a possible solution.
Issue Analytics
- State:
- Created 2 years ago
- Reactions:3
- Comments:7 (3 by maintainers)
Top GitHub Comments
many thanks @Don-Leopardo ffor your interest i made the required modifications manual as you did in the PR tell the issue be marged to producation
and its working ok
@ankush can marge this to producation please