APP_NAME in bake.hcl undefined apparently + notes on app

Docker version 20.10.7, build f0df350

I have enjoyed using Frappe and created my first app. Thank you @vrslev for creating the guide, very useful.

I did find the following bug.

error: docker-bake.hcl:14,20-28: Unknown variable; There is no variable named "APP_NAME"., and 3 other diagnostic(s)

I was able to work around this by adding the following to the docker-bake.hcl file.

variable "APP_NAME" {
	default = "docbridge"
}

A couple of other notes:

• Might be good to have the list of files to copy formatted in a list instead of in a paragraph.
• Might be worth noting that you need to run the docker build… command from the root of your app instead of from frappe_docker
• https://github.com/castlecraft/custom_frappe_docker If this is no longer the easiest approach to creating custom app builds, it might be worth updating it’s README.

I should really learn how to do a PR…

[1ubuntuuser]

Alrighty… I’ll giveup on that idea. I kinda get why production images should be static but I also think it’s pretty limiting to the eco system to not allow apps to be shared easily.

Anyway, I will just use your https://github.com/castlecraft/custom_frappe_docker repo to package multiple apps.

Perhaps loading apps dynamically will be considered for the next version. Thanks for your consideration anyway.

[revant]

production images won’t work for static assets. static assets are built and packed into nginx. install-app from worker image just takes care of install in python environment.

in case you use bench image, no need to mount each frappe-bench separately, just mount the workspace like this https://github.com/frappe/frappe_docker/blob/main/devcontainer-example/docker-compose.yml

you will need supervisor to achieve what you need to. just change the frappe/bench image for that.

personally, I’ll not accept apps in volume for other images than frappe/bench.