Missing `VOLUME` declaration for exposed directories

Description of the issue

When deploying Docker containers to AWS ECS, and using EFS mounts, the files from the directories /home/frappe/frappe-bench/{sites,sites/assets} are not copied to the mounted dir.

Context information (for bug reports)

Explanation of the issue: https://github.com/aws/containers-roadmap/issues/863

Steps to reproduce the issue

1. Deploy a Fargate Task with an EFS mounted as /home/frappe/frappe-bench/sites
2. Log into ECS container
3. Do an ls inside /home/frappe/frappe-bench/sites

Observed result

Empty dir

Expected result

Files from the image to be copied into the mounted dir.

Stacktrace / full error message if available

N/A

Solution

Define volumes inside Dockerfile:

VOLUME ["/home/frappe/frappe-bench/sites"]

[revant]

some things were added in python code when containers were not used.

things that I can remember

• website_theme.py calls nodejs command with custom js script to generate theme, it needs node_modules with node-sass installed https://github.com/frappe/frappe/blob/ad7c0816f8e5f455aeb869132dda46980fe78966/frappe/website/doctype/website_theme/website_theme.py#L84
• somewhere it checks assets or fails during bootstrap
• ERPNext setup wizard failed due to missing js
• custom apps code? custom Jinja with js?

[moltar]

Thanks, will close for now then.