Test results on commit 1f2a9e4
See original GitHub issueThe test on commit 1f2a9e4 resulted in the following observations:
-
Original spec requires delivery of Linux Docker images, not Windows or MacOS. Pursuing Windows or MacOS solutions is not part of the original spec. Hence the video showing how to deploy on a Linux server as similar to production as possible.
-
At the end of the video the API explorer version 0.1.0 appears to be different than the version listed in the package.json file 1.0.0 .
-
The instructions in the Welcome to chapter README say for development to clone the app from the chapter repository, however in the development README the suggestion is to fork the repository first, then clone the fork. Should the main README have some added verbiage suggesting the fork and referencing the development readme for further instructions.
-
Package.json
shows the node requirement at version 10.x however at the time of testing the latest node version 13.x was installed. Should package json list node at>=10
? -
The app appeared to be not working in the last commit… I tried the cloning a while back and the app was working, not sure how long ago. There is no obvious continuous integration testing being done. We have no clear visual feedback badge notifying if the tests are passing or failing.
Issue Analytics
- State:
- Created 4 years ago
- Comments:15 (13 by maintainers)
Top GitHub Comments
@timmyichen @Zeko369 I agree with Fran to have a without-docker instructions in CONTRIBUTING. But we must highly recommend use of docker setup wherever its possible as manual setup can trigger a lot of different errors. (Windows 32 bit user here 😛)
So docker should be our primary development setup and then if for some reason people can’t use docker they are free to experiment with manual setup. What do you think?
Btw, I think we can close this issue as we have already answered the OP’s concerns.
Is it a steep learning curve? It’s certainly more beginner-friendly than AWS marketplace.
docker-compose up
docker-compose exec app
That’s about it when it comes to developing with docker on Chapter.
It’s also worth noting that all this discussion is to ease development work. Deployment procedures can always be modified in the future but as it stands we’re not quite there yet.