[Beta] Suggested Description Changes—Work with Dynamic Data in D3 Challenge
See original GitHub issueChallenge work-with-dynamic-data-in-d3 has an issue.
User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_4) AppleWebKit/603.1.30 (KHTML, like Gecko) Version/10.1 Safari/603.1.30
.
Part of the trigger for raising this issue is the incorrect use of “couple”, instead of “couple of”, in the D3 challenge in question (id: 587d7fa7367417b2b2512bc5). Another instance can be found in the challenge Use the d3.max and d3.min Functions to Find Minimum and Maximum Values in a Dataset (id: 587d7fac367417b2b2512bdc).
If I’m not mistaken, the use of simple past when describing a fact, such as in the sentence “The last couple of challenges covered the tools…”, is also incorrect.
I think the description in the title challenge could use a rework—there are many ideas being explained but, in my opiniong, the current text is potentially confusing, particularly to non-native speakers. For example, the sentence “since the data from the dataset array is attached to each element, the callback function has access to it” appears to be misleading because, if I’m not mistaken, each h2
element only has access to an item in dataset
that the element is mapped to.
I am more than happy to suggest a reworked description, but am not entirely sure how to go about it; not least because these changes can be subjective and I’m not entirely confident that I will be able to explain those concepts clearly with my lack of coding experience.
Many apologies in advance for any inconvenience caused—I have’t had to report any issues or used GitHub beyond basic version control up until now. 😦
Issue Analytics
- State:
- Created 6 years ago
- Comments:8 (7 by maintainers)
Top GitHub Comments
Made the change here: #15539
@honmanyau - thanks for your suggestions! To avoid ambiguity, I think we can change the instances of “The last couple challenges covered” to “The last two challenges cover …”.
I wasn’t sure where you were referencing for your other comment, but that sentence should be clarified as you suggest. Perhaps we could say “since one item from the dataset array is attached to each element…” or something similar. If you can create a re-write of the segment so it’s clear for non-native English speakers in any other way, that would be ideal. You can post it as a comment here and we can comment or change it as needed. Thanks so much!