[beta] Unable to give any visual feedback in these anchor tags with text-align property
See original GitHub issueChallenge create-visual-balance-using-the-textalign-property has an issue.
User Agent is: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36
.
Please describe how to reproduce this issue, and include links to screenshots if possible.
I think that there is one more thing missed in that challenge. The final note says:
When you align the two anchor tags, you will see no difference. This is
because text is aligned to the left
by default.
But, to be honest you are unable to see any change, even if you use text-align with other values as center, right, start, end…
So, I think that portion of the challenge needs to be changed. If we are unable to give any visual feedback in these anchor tags they need to be changed.
<style>
h4 {
text-align: center;
}
p {
text-align: justify;
}
.links {
margin-right: 20px;
text-align: left;
}
.fullCard {
border: 1px solid #ccc;
border-radius: 5px;
margin: 10px 5px;
padding: 4px;
}
.cardContent {
padding: 10px;
}
</style>
<div class="fullCard">
<div class="cardContent">
<div class="cardText">
<h4>Google</h4>
<p>Google was founded by Larry Page and Sergey Brin while they were Ph.D. students at Stanford University.</p>
</div>
<div class="cardLinks">
<a href="https://en.wikipedia.org/wiki/Larry_Page" target="_blank" class="links">Larry Page</a>
<a href="https://en.wikipedia.org/wiki/Sergey_Brin" target="_blank" class="links">Sergey Brin</a>
</div>
</div>
</div>
Issue Analytics
- State:
- Created 7 years ago
- Reactions:1
- Comments:7 (4 by maintainers)
Top GitHub Comments
I will submit a PR to address this issue.
Hi Vinay,
Thanks for sharing your solution.
Yeah! I think your solution moves the anchor tag to left, and is also able to move to right.
However, the goal of this particular challenge is teaches about
text-align
property.The float property is another level of knowledge and that takes the HTML element
out of the normal flow
of a document, as explained in the next section of Applied Visual Design.