Broken Test - Refactor Global Variables Out of Functions in JS curriculum

Affected page

https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures/functional-programming/refactor-global-variables-out-of-functions

Your code

// The global variable
const bookList = ["The Hound of the Baskervilles", "On The Electrodynamics of Moving Bodies", "Philosophiæ Naturalis Principia Mathematica", "Disquisitiones Arithmeticae"];

// Change code below this line
function add(bookList, bookName) {

  
  return [...bookList, bookName]
  
  // Change code above this line
}

// Change code below this line
function remove(bookList, bookName) {
  const book_index = bookList.indexOf(bookName);
  if (book_index >= 0) {

    bookList.splice(book_index, 1);
    return bookList;

    // Change code above this line
    }
}

// console.log(bookList)
// console.log(remove(bookList, "The Hound of the Baskervilles"))
// console.log(bookList)

Expected behavior

Test shouldn’t accept this answer as bookList was modified

System

• Device: MacBookPro11,5
• OS: MacOS 11.6.1
• Browser: Chrome
• Version: Version 99.0.4844.51 (Official Build) (x86_64)

Request

I’m new around here and this is my first contribution to FCC. If appropriate I would like to try and fix this bug

[naomi-lgbt]

Thanks for reporting this issue. I agree with Jeremy that addressing the global state issue still needs to be done. However, this specific issue can be fixed independently.

We do have a test which checks that the bookList array is unmodified, but it only tests the add function and not the remove function. IMHO, it would be sufficient to add a remove call in that first test.

[raditotev]

I am sorry @csabsen, I just saw you’re still interested in fixing this issue. I can close my PR, so that you can fix the issue yourself. Let me know if that is what you want.