challenge description and solution needs updating to align with MDN best practice
See original GitHub issueChallenge: “Basic HTML and HTML5 - Create a Set of Radio Buttons” https://learn.freecodecamp.org/responsive-web-design/basic-html-and-html5/create-a-set-of-radio-buttons
Here is the relevant text in the description for this challenge:
Each of your radio buttons should be nested within its own label element. Wrapping an input element inside of a label element makes the label text clickable.
It is NOT necessary to wrap an input element inside of a label element to make the text clickable as long as there is a for
field on the label that matches the id
of the input. The recommendation on fCC is contrary to what is shown at MDN: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/radio
Same for checkboxes. This should be changed as well to match best practices shown on MDN.
It works either way so this is not necessarily an error but I think it is best to change this to go along with MDN.
Issue Analytics
- State:
- Created 5 years ago
- Comments:7 (7 by maintainers)
Top GitHub Comments
And to further clear any confusion log any issue on any of the repositories.
We (@freeCodeCamp/moderators) will take care of moving them around as needed. There is a chrome extention that makes this as simple as clicking a few buttons.
To clear any confusion, curriculum issues belong here, platform issues belong in the learn repo.
We will be publishing the seed files as an npm package shortly, so the seed files held in learn will no longer exist