Dealing with legacy lifecycle methods

As mentioned in https://github.com/freeCodeCamp/freeCodeCamp/pull/35894 and https://github.com/freeCodeCamp/freeCodeCamp/pull/35895#issuecomment-508145165 there are still challenges that use legacy React lifecycle methods.

Let’s discuss what we should do with those challenges.

Personally, I think the challenge that uses them should simply be removed. Quoting the React blog:

some of our legacy component lifecycles tend to encourage unsafe coding practices

So, not something we need to teach.

The other challenge has componentWillReceiveProps, but it is not integral to the challenge. If the method is removed, I think that challenge will be fine.

[ojeytonwilliams]

@jonathan-grah As I understand it, there’s no point making significant changes since those changes will only be temporary. However, these changes would be pretty trivial.

@thecodingaviator isn’t it worth keeping “Optimize Re-Renders with shouldComponentUpdate”? The fix is pretty simple. We delete

componentWillReceiveProps(nextProps) {
  console.log('Receiving new props...');
}

from the seed and solution and change “the other lifecycle hooks are triggered” to “the lifecycle hooks are triggered”. I’d be happy to create the PR for this.

[thecodingaviator]

@ojeytonwilliams I’m onboard with that, I think you should go ahead and make the PR