i18n: Handling Missing Files
See original GitHub issue@RandellDawson and I pulled down #40906 to test the build. Adding espanol
to the allowed curriculum languages allowed the ensure-env
run to pass, as expected. We added responsive-web-design
to the is-audited.js
, and ran clean-and-develop
.
The GraphQL query errors out, presumably because the espanol
folder is missing challenges, presumably.
The build fails, and the development instance will not load.
While the intention is to have a 100% completion of a superblock prior to enabling it in is-audited.js
, this will potentially become a significant issue going forward as we add/remove challenge files. There are definite concerns here, especially looking forward to the V7 curriculum, where modifications to the flow will break or block deployments.
@ojeytonwilliams - is it possible I missed a configuration during the testing? I noted the comment in the is-audited.js
file that explicitly states the superblock should be 100% complete, so a build error is what I was expecting, but is this the ideal approach?
@raisedadead - I’m not sure of the specifics of the deployment pipelines. Would a merge to production-current
trigger a build on all i18n sites simultaneously? Or are we able to push each one independently?
Issue Analytics
- State:
- Created 3 years ago
- Comments:19 (19 by maintainers)
Catching up on the conversation in chat…
I pulled down the
i18n-sync-learn
branch, changed theis-audited
andallLangs
values to allow the espanol curriculum, and ran a development build. It looks like we’ve configured Crowdin correctly to send down source files for incomplete translations - I had no build errors this time and was able to explore the curriculum.I think this is safe to close now. 🙂
Yes and no. If we can get all the files from Crowdin, defaulting to translated when we want to, that’s fine. However, if we can’t then we’ll need to re-work how we build the translated curricula.
So, in a slight rush I asked Nick to wait. However if we just want to test things out, it’s fine to copy the English over to the Spanish for now.
How we handle things depends on precisely what we’ll be getting back from Crowdin, but for testing it’s fine.