Incorrect Test expectation for Confirm the Ending Challenge

Challenge Confirm the Ending has an issue. User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.103 Safari/537.36. Please describe how to reproduce this issue, and include links to screenshots if possible.

1. Added console log statements to check the work, and I see that me and name do not match and should be false, but the test is expecting it to be true.

If I understand the challenge correctly, it’s to make sure that the last letter or word in the string matches the target respectively. The last word of the string “He has to give me a new name” is name, and the target is “me”. me and name do not match so the test, confirmEnding(“He has to give me a new name”, “me”) should return true, should actually return false; correct?

My code:

function confirmEnding(str, target) {
  // "Never give up and good luck will find you."
  // -- Falcor
  var match;
  if(target.length === 1) {
    match = target == str.substring(str.length-1, str.length);    
  } else {
    var words = str.split(" ");
    var lastWord = words[words.length-1];
    match = target === lastWord;
  }
  return match;
}

confirmEnding("Bastian", "n");

[BKinahan]

@jlheard You know, that’s something I hadn’t considered before. I didn’t realize the confusion was coming from the fact that the word "me" appears earlier in the string, so thanks for pointing that out! 😄

I like the idea for using the phrase “Open sesame” (with title case to match the other tests rather than camelCase). It might be good to replace these two tests:

confirmEnding("He has to give me a new name", "me") should return true. confirmEnding("He has to give me a new name", "na") should return false.

with:

confirmEnding("Open sesame", "same") should return true. confirmEnding("Open sesame", "pen") should return false.

They test for similar conditions but should be much clearer without that ambiguity about an earlier-appearing string recurring at the end.

[erictleung]

@jlheard thanks for the issue. I also didn’t know where the confusion was coming from.

@BKinahan I like your suggested changes to those two tests 👍