Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[learn] tests should fail when code has error

See original GitHub issue

I entered a valid solution and passed all the tests in the picture below. Then I added the a on the second line: var collection = { a - to make the build fail, but all the test results still have the green check mark like they passed. I think they should go back to failed if there’s an error.

Issue Analytics

State:
Created 4 years ago
Comments:18 (18 by maintainers)

Top GitHub Comments

1reaction

ojeytonwilliamscommented, May 11, 2019

@Stevo99 As Mrugesh said on Gitter, the codebase is a bit complex. The bit responsible for updating the test results is https://github.com/freeCodeCamp/freeCodeCamp/blob/1c669fd56838b68710062bc09f6e4af34e7cf709/client/src/templates/Challenges/redux/execute-challenge-saga.js#L56-L61 and you can see that if there’s an error (which is the case we’re looking at) only the console gets updated, not the tests.

One approach would be to look at the code in https://github.com/freeCodeCamp/freeCodeCamp/blob/1c669fd56838b68710062bc09f6e4af34e7cf709/client/src/templates/Challenges/redux/execute-challenge-saga.js#L82 for inspiration and try to figure out a way to update the tests so they all show as failing.

0reactions

Sfaillacommented, May 18, 2019

It’s better to set an initial state for tests at the beginning

@ValeraS So a few of the Team Members said that your suggestion is the best way to fix this issue. I’m not that experienced with this codebase and I was just wondering if maybe you can explain how I can go about setting an initial state for the tests. I tried to figure it out myself but could not unfortunately. Any help would be appreciated. Thanks!!