Link to External Pages with Anchor Elements test is too permissive

Describe your problem and how to reproduce it: the challenge can be passed with an url like href="https://freecatphotoapp.com.", or href="https://freecatphotoapp.com/stuuyuuufushtfgh"

Add a Link to the page with the problem: https://www.freecodecamp.org/learn/responsive-web-design/basic-html-and-html5/link-to-external-pages-with-anchor-elements

Suggestion:

-assert(/https:\/\/(www\.)?freecatphotoapp\.com/gi.test($('a').attr('href')));
+assert(/^https:\/\/(www\.)?freecatphotoapp\.com$/i.test($('a').attr('href')));

• add anchors to make sure that the link is exactly that with no extra stuff around
• remove the g tag which in this case is just useless
• ~[possibly] add the possibility to have an http link pass, seeing that the video hint show that link (it shows an example https, and then it deletes the s)~

[naomi-lgbt]

[possibly] add the possibility to have an http link pass, seeing that the video hint show that link (it shows an example https, and then it deletes the s)

I’d vote against this one, personally. The http vs https often trips up campers, but I think that’s an important bit that calls attention to the fact that the protocol matters.

add anchors to make sure that the link is exactly that with no extra stuff around remove the g tag which in this case is just useless

These I very much agree with and, provided no one disagrees, would gladly open this up to contributions.

[naomi-lgbt]

An issue with the help wanted or first timers only label is open for contribution. The first comprehensive PR created will be reviewed and merged. We typically do not assign issues to anyone other than long-time contributors.

If you would like to contribute, and have not read the contributors docs, please do so here: https://contribute.freecodecamp.org/#/

If you have any issues with contributing, be sure to join us on the contributors channel, or on the contributors sub-forum