Make Cafe Menu Step 37 instructions a little clearer
See original GitHub issueDescribe the Issue
Most of the description for step 37 is about styling p
elements. It even states that “you need to apply some styling to the p
elements”. But then suddenly the last line instructs the user to add a class
to an article
, which seems a little confusing and out of place. This caused a least one camper to add a new p
element in this step and apply the class attribute to that element.
Affected Page
Your code
Campers code:
<article>
<p class="item"></p>
<p class="flavor">French Vanilla</p>
<p class="price">3.00</p>
</article>
Expected behavior
Even though the last line is clear that the class should be added to the article, I think it could be made less confusing if we explained that this is in preparation for styling the p
elements. Perhaps change the last sentence to something like:
To help with styling the
p
elements, you will first add aclass
attribute with the valueitem
to the firstarticle
element under theCoffee
heading.
Screenshots
No response
System
- Device: [e.g. iPhone 6, Laptop]
- OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04]
- Browser: [e.g. Chrome, Safari]
- Version: [e.g. 22]
Additional context
No response
Issue Analytics
- State:
- Created a year ago
- Reactions:2
- Comments:7 (4 by maintainers)
Top GitHub Comments
I think that what’s missing is explaining shortly why we add the class to the parent element and not directly to the
p
elements. Like you said, the confusion comes from why we are suddently targeting thearticle
element, when the focus of the lesson was styling thep
elements.i.e we don’t
need
to target the parent element, it’s just cleaner.@Sboonny what do you think ?
How about: