question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Need a stricter test for the Add Placeholder Text to a Text Field challenge

See original GitHub issue

This is an issue raised by @huyenltnguyen on PR #26458.

The tests pass even for invalid code (adding the closing tag). We need to discuss here what the best “fix” is for this issue. It could be a modification an existing test or adding a new test which checks to make sure the user’s code does not have a </input> tag after the <input> tag.

Once we finalize what the fix should do, we will attach a Help Wanted label on this issue. Please wait until we have added this label before creating PRs for this issue.

Thank you.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:7 (7 by maintainers)

github_iconTop GitHub Comments

1reaction
RandellDawsoncommented, Jun 5, 2019

@minggas Give it a try and we can test it for edge cases.

0reactions
minggascommented, Jun 5, 2019

I can implement that solution. I will add one more test to see if the input has a closing tag and and one more match in the final catchall to get anything that pass the limit of the <input /> final >. Any thoughts?

Read more comments on GitHub >

github_iconTop Results From Across the Web

Add Placeholder Text to a Text Field Free Code Camp Org ...
FOLLOW ALONG LINK: https://www.freecodecamp.org/learn/responsive-web-design/basic-html-and-html5/ add - placeholder - text -to-a- text -fieldCheck ...
Read more >
Basic HTML and HTML5: Add Placeholder Text to a Text Field
Placeholder text allows the programmer to put text in the background of an ' input ' HTML element so that the user has...
Read more >
Add Placeholder Text to a Text Field, freeCodeCamp review ...
freeCodeCamp tutorials, review and help, in this challenge we learn how to add place holder text inside of our input box.
Read more >
Don't Use The Placeholder Attribute - Smashing Magazine
When a person enters information into an input, its placeholder content will disappear. The only way to restore it is to remove the...
Read more >
Forms · Bootstrap v4.5
<input class="form-control" type="text" placeholder="Readonly input here. ... Add .position-static to inputs within .form-check that don't have any label ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found