Profile lookup passes invalid code.

Challenge Name

Profile Lookup

Issue Description

The test for no such property passes even when the code does check firstName value. Because the test for no such property uses the first contact in the array the test will pass even if the code does not check for matching first name

Browser Information

Chrome on windows - 52.0.2743.116

Your Code

This code passes but shouldn’t per instructions

 function lookUpProfile(firstName, prop){
// Only change code below this line
for(var i = 0; i< contacts.length; i++){
   if(contacts[i].firstName == firstName && contacts[i].hasOwnProperty(prop)) {
      return contacts[i][prop];
    }
   if(contacts[i].hasOwnProperty(prop) === false) {
       return "No such property";
   }
}

return "No such contact";
// Only change code above this line
}

[sjames1958gm]

The change provided didn’t test the case indicated. The property “number” is on every contact, the new test should have been something like profileLookup(“Bob”, “email”)

[rgtalbot]

The instructions are fine, you need another test to stop people from passing with bad code if you test it against lookupProfile(“Bob”, “likes”), the bad example above will return Akira’s likes. Simply adding another test to pass will close this. Add this test @Bouncey.