Running code in isolation, when global declarations are used

Challenge Name

Steamroller in Intermediate Algorithm Scripting

Issue Description

I used a recursive function to complete this challenge and when tested the called challenge function returns the correct value but my challenge is not marked as completed and the tests do not pass.

Browser Information

Chrome Version 65.0.3325.146 (Official Build) (64-bit) on Windows 10 x64 (Desktop)

• Browser Name, Version:
• Operating System:
• Mobile, Desktop, or Tablet:

Your Code

var newArr = [];

function testArr(item){
  if (Array.isArray(item)) {
    for (let i = 0; i < item.length; i++) {
      testArr(item[i]);
    }
  } else { 
    newArr.push(item);
  }
}

function steamrollArray(arr) {
  // I'm a steamroller, baby
  for (let i = 0; i < arr.length; i++){
    testArr(arr[i]);
  }
  return newArr;
}

steamrollArray([1, {}, [3, [[4]]]]);

Screenshot

[raisedadead]

Yes, this is a platform limitation with use of global methods. While its also not recommended to use globals, I understand that this intent is not very clear.

The tests are not run in isolation, and hence the last value of your globals persist, breaking them.

We of course can’t make any changes, to the current production at freeCodeCamp.org, however we should discuss the possibility of at least making the intent known in some form on beta.

Same challenge on beta, for reference debugging: https://beta.freecodecamp.org/en/challenges/intermediate-algorithm-scripting/steamroller Originally reported in https://github.com/freeCodeCamp/freeCodeCamp/issues/9063

[QuincyLarson]

I’m closing this issue as stale since it hasn’t been active lately. If you think this is still relevant to the newly updated platform, please explain why, then reopen it.