Smallest Common Multiple -- add a note about // noprotect

Challenge Name

https://www.freecodecamp.org/challenges/smallest-common-multiple

Issue Description

My code failed the last test, but passed with // noprotect in the top. I figured it out when reading this post. My suggestion is to add a line in the description about // noprotect. Or to update the error message to ask people to make a more efficient algorithm. Otherwise people make inefficient algorithms like mine would be quite confused why it does not pass.

Thanks!

[charlottetan]

I’m not able to reproduce the issue with the code snippets in this thread, this issue can probably be closed.

[mpisters]

I have also this issue with my code (not very optimised):

function smallestCommons(arr){
    const par1 = arr[0];
    const par2 = arr[1];
    let isDividable = false;
    let range = false;
    let number = 1;
    while(!isDividable){
        let diff1 = number % par1;
        let diff2 = number % par2;
        if (number % par1 === 0 && number % par2 === 0 && diff1 === diff2 ){
            const start = par1 >= par2 ? par2 : par1;
            const end = par1 >= par2 ? par1 : par2;
            for(let i = start; i < end; i++){
                if (number % i === diff1){
                    range = true;
                } else {
                    range = false;
                    break;
                }
            }
            if (range){
               isDividable = true;
            }
        }
        number++;
    }
    return number - 1;
}

console.log("does it work?", smallestCommons([23,18]));

When I run this in the chrome browser it works, but in freecodecamp it doesn’t. I also added // no protect but doesn’t seem to work.