Test should ignore whitespace

Challenge Override All Other Styles by using Important has an issue. User Agent is: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:51.0) Gecko/20100101 Firefox/51.0. Please describe how to reproduce this issue, and include links to screenshots if possible.

My code:

<style>
  body {
    background-color: black;
    font-family: Monospace ;
    color: green;
  }
  #orange-text {
    color: orange ;
  }
  .pink-text     {
    color: pink !important ;
  }
  .blue-text {
    color: blue;
  }
</style>
<h1 id="orange-text" class="pink-text blue-text" style="color: white">Hello World!</h1>

Similar to #8511, test is not whitespace tolerant.

[erictleung]

@BlauFeuer thanks for the issue. Yes, the test should be able to accommodate for spaces.

This line of code needs to be changed so that the regex is changed so that it allows zero or more spaces between !important and the semicolon.

- /\\.pink-text\\s*?\\{[\\s\\S]*?color:.*pink.*!important;[^\\.]*\\}/g
+ /\\.pink-text\\s*?\\{[\\s\\S]*?color:.*pink.*!important\\s*;[^\\.]*\\}/g

[dhcodes]

@BlauFeuer You should be able to rename your current branch using: git branch -m new_branch while on the branch you want to rename locally.

Then you can re-push your changes with a git push -u origin fix/branch-name-here --force.

You may need to commit again too between those two steps, though I’m not sure it will be necessary.

As for the guidelines, I think they do a good job of providing a first-timer with a full git experience which can be helpful to someone just getting into contributing.