Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Add commentChar to CSV-DDF

See original GitHub issue

There are CSVs that exist in the wild that begin with some number of commented lines: example (45MB).

To support these kinds of files, we might want to have a new attribute as part of the dialect description: commentChar.

Issue Analytics

State:
Created 8 years ago
Comments:10 (8 by maintainers)

Top GitHub Comments

2reactions

rufuspollockcommented, Mar 2, 2020

@slythfox yes let’s keep it simple and refine as need arises.

1reaction

chrispomeroyhalecommented, Mar 1, 2020

If we keep it to “full line” comments as you both are describing then perhaps we should update CSV-DDF description to make that clear?

On the other hand, if there’s at least one CSV parser (e.g. JS csv-parse) that supports more than “full line” comments I imagine someone’s using it? So, alternatively, we could precisely define specific comment behavior, or add additional attributes to CSV-DDF and having the developer work with what configurations an underlying CSV parser supports.

I’m leaning on keeping it simple (i.e. update the CSV-DDF with clarification) and then add additional CSV-DDF comment attributes if a need arises