Windows: getCurrentConnections returns null when multiple interfaces exist

When there are multiple wifi interfaces exist in Windows environment and if the first one is disconnected, the getCurrentConnections() returns null.

Expected Behavior

The getCurrentConnections() should return connected connections from any interfaces

Current Behavior

When there are multiple wifi interfaces exist in Windows environment and if the first one is disconnected, the getCurrentConnections() returns null.

Affected features

• [Y] node API
• cli

Possible Solution

I have confirmed working after modified the windows-current-connections.js by following:

function parseShowInterfaces(stdout) {
...
    for (var j = 0; j < fields.length; j++) {
      var line = lines[i + j];
//=====  MY CHANGE START
 // tmpConnection[fields[j]] = line.match(/.*: (.*)/)[1];
      const lineMatch = line.match(/.*: (.*)/);
      if (lineMatch == null) { 
        // bad line, skip current interface and move to next one
        i += j + 1;
        j = -1;
      } else {
        tmpConnection[fields[j]] = lineMatch[1];
      }
//=====  MY CHANGE END
...
}

Steps to Reproduce (for bugs)

1. Prepare environment with two wifi interfaces
2. Only connect wifi from second wifi interfaces. I.e. second means whatever it appears in second from ‘netsh wlan show interfaces’
3. Run wifi-node.getCurrentConnections()
4. Check the output.

Context

Your Environment

• OS:
• node-wifi version
• wifi card:

[friedrith]

Ok I will try to propose a fix

[friedrith]

I am glad you found a workaround. Unfortunately, windows use async commands so you don’t know exactly when the job will be finished.