Upgrade to React 16 - Region without empty DIV

The below code block in region.js is not required in React 16, it could be simply returned as a listForRendering.map, React 16 considers array rendering as well and that helps in minimizing bloated HTML.

return _react2.default.createElement(
        'div',
        null,
        listForRendering.map(function (item) {
          var Component = item.Component,
              name = item.name;


          return _react2.default.createElement(Component, { key: 'app-' + name });
        })
      );

[fahadsuhaib]

@fahad19 Sure, that sounds fine, I’ll just fork for now.

[mAiNiNfEcTiOn]

@fahadsuhaib I understand your point of view. However, what I’m trying to say is that this is a breaking change.

Users that have been using the Region component are expecting that a <div> element comes out when rendering AND that they can pass a className as an attribute to that component and it will be used in the wrapper element rendered.

E.g.:

<style>
  .my-custom-class {
    border: solid 1 px black;
    border-radius: 5px;
  }
</style>

<Region className="my-custom-class" name="my-custom-name"/>

In the current state, this would output a <div class="my-custom-class"><!-- Frint Apps here --></div>

With the changes proposed, it would be just <!-- Frint Apps here -->.

If I update to the new way, the styles on the <style> would not be used anymore.

Last but not the least, I’m not against implementing it, but that is a breaking change which implies a new major. Also it means that FrintJS requires React 16 as a minimum. That means that for deprecation and/or migration periods you don’t support previous versions of React.

Bold move, no?