We shouldn't trust Child Apps in Region — anything could happen ©

What do you think about adding componentDidCatch method to <Region /> component?

[mAiNiNfEcTiOn]

This responsibility cannot be delegated to the app developer. It has to be contained under the core system.

In general, browsers act mostly in the same way when it comes to <script src="..."></script> tags.

<script src="vendors.js"></script>
<script src="a.js"></script>
<script src="b.js"></script>

Say that both a.js and b.js, depend on vendors.js (classical type of structure here)…

If a.js has an error, a.js execution stops, but doesn’t block from b.js to run. Vice-versa for b.js

But if by any case, the error happens at the top (vendors.js) because an app is trying to use a method available on the vendors that is not being properly used AND the errors not properly handled, we have a broken page.

Although that should be properly monitored, logged and/or notified to the FB app developer, it should not at any time be a blocker for the whole page. Breaking normal functionality because of a misuse of the FB app dev, it is a big no-no.

[markvincze]

@froskie, I think the idea is that we should both

• surround the registerApp call with a try-catch to catch any errors during app registration.
• implement componentDidCatch to handle any rendering errors.

The work already started in rwd to do this automatically for every app: https://bitbucket.org/xivart/rwd_cheaptickets_nl/pull-requests/5680/mp-223-fb-bundler-handle-errors-from-fb/diff With that in place we don’t have to do anything in the actual apps, and we’ll get a default implementation of componentDidCatch generated by default, which simply hides the app if its rendering throws an error. @fahad19 what’s left to be done in that PR?