Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Conflict in case of instructions regarding output tag

See original GitHub issue

`const express = require(‘express’); const router = express.Router(); const nodeHtmlToImage = require(‘node-html-to-image’);

router.get(/api/tweet/render, async function(req, res) { const image = await nodeHtmlToImage({ html: ‘<html><body><div>Check out what I just did! #cool</div></body></html>’ }); res.writeHead(200, { ‘Content-Type’: ‘image/png’ }); res.end(imgBinary, ‘binary’); });` Here in this sample, you have not given the output tag. But according to the code you mentioned that if there is no output tag it will throw error. Then you should make the use of output tag optional.

Issue Analytics

State:
Created 3 years ago
Reactions:1
Comments:7 (5 by maintainers)

Top GitHub Comments

1reaction

shankha007commented, Apr 21, 2020

You better do it for now. I am little bit busy in my project…

On Tue, Apr 21, 2020 at 4:25 PM Yvonnick FRIN notifications@github.com wrote:

👋 @shankha007 https://github.com/shankha007 I need this before publishing a new version. Do you think you have time to do it in the next few days or should I do it myself?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/frinyvonnick/node-html-to-image/issues/12#issuecomment-617105872, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM6T7A7ZRMQAFC5KHI2ZM43RNV3RHANCNFSM4MKO7CUQ .

0reactions

frinyvonnickcommented, May 12, 2020

This was fixed in #16 and published in 2.0.0