searchMatches are never updated
See original GitHub issueI’m copy the example from here and can’t get the search focus/highlight working.
I debug the code and see that getDerivedStateFromProps
is called a first time ( after pass the searchQuery={text}
) and it does .search()
and return the searchMatches
, but it is called again and in this second time it just returns the instanceProps
and the prevState that came in this second time has the searchMatches
empty.
I have the same dependencies like the sandbox, react/react-dom 16.9.0-alpha-0 and I also try with the previous one 16.8.6 but can’t get it working.
I also literally copy the codesandbox.io code and put in in the main of my app, but it didn’t work.
I can’t reproduce or debug the state/error in https://codesandbox.io
If someone could give some idea or point me in some direction to understand this I will really appreciate it.
Issue Analytics
- State:
- Created 4 years ago
- Comments:5
Top GitHub Comments
Out of curiosity, were you using this within a create-react-app running in development mode?
I also ran into this issue when using this library in an application bootstrapped via create-react-app, and I believe the double call to
getDerivedStateFromProps
is a symptom of StrictMode: https://github.com/facebook/react/issues/15074#issuecomment-471197572. After running a production build and serving the application, the issue disappeared.I fixed it in this fork https://github.com/nosferatu500/react-sortable-tree/pull/32. For someone who wish to use this library you can use it instead.