Harmonize Config/Configuration/PropertyAttribute

As noted in #420 we have about a handful of configuration types that have slightly different property names.

As much as possible we should limit the number of different configuration types. At least make all the names the same to avoid confusion.

Also, the basic Config type https://github.com/fscheck/FsCheck/blob/master/src/FsCheck/Runner.fs#L39 should become a POCO mutable type - that means we can probably get rid of a few wrappers. And also, F# record types in a public API are basically a big no-no, as they can’t be changed without breaking compatibility.

This should happen on the fscheck3 branch, and where possible add/deprecate in v2.

[LaurenceJKing]

Hi, I was just taking a look at this issue, to see if I could sort it out. I have a question about Replay value.

//in RunnerExtensions.fs member __.Replay with get() = (match replay with None -> Unchecked.defaultof<uint64*uint64*int> | Some s -> (s.Rnd.Seed,s.Rnd.Gamma,defaultArg s.Size 0)) and set(v) = replay <- Some <| let s,g,size = v in { Rnd = Random.createWithSeedAndGamma (s,g); Size = if size = -1 then None else Some size }

When we get the Reply property, we get 0 if Size is none. But when we set the Replay property, Size is only set to none if the value is -1.

Is there any particular reason for this?

[kurtschelfthout]

Making one type is one way to approach this, yes. Maybe you can use overloads with both FSharpFunc and Func, or use the trick elsewhere of making the “core” type F# friendly and then having C# friendly extension methods on it (see e.g. Arbitrary and ArbitraryExtensions etc). In any case I don’t want to choose one over the other, there is normally a way (typically overloading and using attributes to hide methods from intellisense in one language but not the other etc) to present a nice interface to both languages.