Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

patern match in filenames (without reading content)

See original GitHub issue

The pattern matching works very well with “dir.readFiles()” but couldn’t figure it out for dir.files(). The exclude and include examples do not seem to be supporting glob-like matching or regex. Here is a sample to illustrate the issue:

dir.files(myDir, { match: /pattern/ }, function(err, files) {
    if (err) throw err;
    console.log("files)
  });

When executed, this throws a callback error:

node_modules/node-dir/lib/paths.js:25
            callback(null, results);
            ^

TypeError: callback is not a function
    at done (..node_modules/node-dir/lib/paths.js:25:13)
    at ..node_modules/node-dir/lib/paths.js:53:37
    at done (..node_modules/node-dir/lib/paths.js:25:13)
    at ..node_modules/node-dir/lib/paths.js:60:33
    at FSReqWrap.oncomplete (fs.js:82:15)

Issue Analytics

State:
Created 7 years ago
Comments:5

Top GitHub Comments

2reactions

photonstormcommented, Jan 18, 2017

I hit this same error today, but it’s nothing to do with pattern matching - dir.files just doesn’t accept an object as the second argument. I was trying with:

var files = dir.files(__dirname, { sync: true });

… and it fails in exactly the same place, because the signature for files is expecting something different. Looking at the code this is a problem in v0.1.16 which is the most recent version published to npm, but looks fixed in v0.1.17 which is in this repo, but not on npm.

1reaction

ellisiumcommented, Apr 24, 2017

Latest npm version is 0.1.16 while git latest version is 0.1.17. Please update it to let us use npm install