question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Review naming conventions

See original GitHub issue

I think this project started with original Aeson names, which at the same time are Haskell-ish names.

I propose we use instead more F#ish names, which means that instead of fromJSON we should use ofJSON.

This can be implemented without breaking changes, by adding another default overload, or by renaming the recently added default for FromJSON with a clean signature, since it wasn’t released yet.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Reactions:2
  • Comments:10 (10 by maintainers)

github_iconTop GitHub Comments

1reaction
wallymathieucommented, Apr 25, 2018
1reaction
gustycommented, Apr 25, 2018

Yes, they both compile to the same in the end, so from other language they are indeed the same thing. But even in F# they are just an implementation detail.

I propose to open a suggestion here: https://github.com/cartermp/docs/blob/style/docs/fsharp/style-guide and take this discussion there.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Document naming conventions - Records & Information
Document and review. Ensuring naming conventions are documented and made accessible to current and future staff, and included in local staff on-boarding ...
Read more >
File Naming Conventions & Version Control
Decide on a file naming convention to use whenever you create a document. Useful file names: are consistent; are meaningful to you and...
Read more >
File Naming Conventions: simple rules save time and effort
The simple rules apply equally to electronic and physical files and folders. They provide assurance that the correct item is retrieved and cannot...
Read more >
File Naming Conventions
A file naming convention is a framework for naming your files in a way that describes what they contain and how they relate...
Read more >
Naming convention (programming)
In computer programming, a naming convention is a set of rules for choosing the character sequence to be used for identifiers which denote...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found