HttpClient is created for each request which is anti-pattern

Description

This line means that each property access creates on new HttpClient https://github.com/fsprojects/FSharp.Data.GraphQL/blob/0f34f8fda9387f1fbba2294d8ff5c2f4e01f90bc/src/FSharp.Data.GraphQL.Client/GraphQLProviderRuntimeContext.fs#L20 Hence Dispose is called on a new instance. And creating HttpClient for each request is an anti-pattern.

Expected behavior

1. HttpClient is created once.
2. User can provide his instance of HttpClient

Actual behavior

HttpClient is hardcoded and created on each property access.

Related information

• FSharp.Data.GraphQL 1.0.5

[ivelten]

I was searching a bit about HttpClient, more specifically about a Singleton/Caching usage of it, and I came to this thread. I guess we could avoid implementing a default instance using those approaches, as we could potentially run into DNS changes depending on the user. Instead, I just removed the HttpClient re-instantiation on each property access, and allowed the user to manage its own connection instance by passing a factory to an overload of GetContext method.

Here is the PR with my proposal.

[xperiandri]

I hope to present a fix for tomorrow