Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Generator ignores nullability

See original GitHub issue

Description

    Service:
      type: object
      properties:
        Услуга:
          type: string
        Стоимость:
          type: number
          format: ₴
          nullable: false
        Обязательная:
          type: boolean
          nullable: false

Expected behavior

Properties of value type marked as nullable: false declared as non-nullable and has a non-nullable parameter in a constructor

Actual behavior

nullable: false is ignored

Related information

1.0.0-Beta1

Issue Analytics

State:
Created 3 years ago
Comments:5 (4 by maintainers)

Top GitHub Comments

1reaction

Numpsycommented, Apr 13, 2021

Could that be because the fields aren’t marked as required in the schema, so the generated properties have to be optional to handle them not being present in the Json data?

0reactions

sergey-tihoncommented, Jan 31, 2021

Here is the line where we determine if the property is optional. https://github.com/fsprojects/SwaggerProvider/blob/net5/src/SwaggerProvider.DesignTime/v3/DefinitionCompiler.fs#L202

Is easiest way to debug is to put breakpoint on this line and check how Microsoft.OpenApi.Readers passed your schema.