question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Implement _get_kwargs_from_urls

See original GitHub issue

Using URLs is very convenient, it allows configuring the storage via a single environment variable.

However S3FileSystem does not implement _get_kwargs_from_urls so it is impossible to specify anything via the URL, only the bucket.

It would be good to have S3FileSystem parse query arguments, such as endpoint_url (useful for testing locally with Minio for instance), region_name, requester_pays, signature_version, and timeouts.

Right now I have to do my own parsing on the URL to pass it to S3FileSystem, which duplicates the effort in fsspec.

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Reactions:3
  • Comments:15 (8 by maintainers)

github_iconTop GitHub Comments

5reactions
DavidMStraubcommented, Jan 7, 2020

I think this is a great idea.

I bumped into this thread while trying to find out if I can specify the endpoint_url when using the s3fs implementation in pandas, when doing things like pd.from_csv("s3://..."). Given the proliferation of S3-compatible object storage provides, I think this is an important use case. Unfortunately, the pandas implementation does not allow to pass any arguments to S3FileSystem.

Moreover, I found a recent PR in pandas implementing this via environment variables (https://github.com/pandas-dev/pandas/pull/29050) and it was closed by the panda devs arguing that this should be implemented in s3fs instead.

I think making these options configurable via the URL string would be the perfect solution.

2reactions
martindurantcommented, Jun 10, 2020

Note that following https://github.com/pandas-dev/pandas/pull/34266 , it should become possible to pass parameters to the filesystem backend sometime in the future.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Access kwargs from a URL in a Django template
In the view, you can access the URL args and kwargs as self.args and self.kwargs . class MyView(View): def my_method(self): this_name ...
Read more >
URL designing and URL kwargs in Django
URL designing and URL kwargs in Django ... A clean URL is really important for a good quality web application. You can design...
Read more >
Chapter 8: Advanced Views and URLconfs - The Django Book
When a request comes in, Django tries to match the URLconf patterns against the requested URL, as a Python string. This does not...
Read more >
django.urls utility functions
reverse() ¶ ... If you need to use something similar to the url template tag in your code, Django provides the following function:...
Read more >
URL parameters in views - GitHub Pages
If you don't modify the view like this, it simply won't work — you'll get an exception, because Django will attempt to call...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found