getAvailableLocaleCodes not refreshing when new locales are fetched dynamically

In our code we fetch new locales dynamically and then eval them. This seems to work fine, that is, the calendar uses the new locale just fine when we do calendar.setOption('locale', locale). However, calendar.getAvailableLocaleCodes() returns only the ones that were available when the calendar was created and doesn’t reflect the newly added ones. In version 3 we did the same with $.fullCalendar.locales and it did refresh when we evaled new locales.

P.S. Another thing is that the firstDay doesn’t change when calendar.setOption('locale', locale) is invoked. It only dynamically changes when a new calendar is created. Should I open a new issue for that?

[acerix]

Loading locales after the calendar was initialized wasn’t documented in v3 so I think it’s not really a regression but I can leave this open as a feature request.

[boris-petrov]

@arshaw - well, this issue is even worse in FullCalendar version 5. The locales there are not browserified and one cannot simply import them dynamically in a website:

var enGb = {
  code: "en-gb",
  week: {
    dow: 1, // Monday is the first day of the week.
    doy: 4  // The week that contains Jan 4th is the first week of the year.
  }
};

export default enGb;

I have configured my bundler to copy these locales to my distribution and then I have setup code to dynamically load locales as requested by the user - in order to not download to that user all locales upfront.

In version 4 that worked fine because the locale files were browserified. But then getAvailableLocaleCodes didn’t “refresh” when a new locale was added - I had to create a new Calendar instance for it to work.

In version 5 I have to manually “fix” the locale files to work in a browser. And I removed my workarounds with creating a new Calendar instance and all that.

So the issue can be closed, yes, even though the underlying problem is still there albeit not relevant any more to me.

Thanks for the support!