incorrect navLink for granularities other than day/week

Hi,

Using navLinks, the day header from resourceTimelineWeek links to resourceTimelineMonth (instead of expected resourceTimelineDay), even with explicit setting navLinkDayClick.

Test case: https://codepen.io/anon/pen/QPzLgo

[arshaw]

The problem here is that the navLink*Click handlers are called in more specific situations that you might think. For example, navLinkDayClick only happens when a whole-day cell is clicked. The reason it’s not firing in the codepen is because an hour-granularity is being clicked (which would hypothetically need navLinkHourClick).

We would need to improve the API to make this less awkward. I’ll propose navLinkClick:

navLinkClick: 'resourceTimelineDay' // for anything that's clicked

// OR
navLinkClick: function(dateClicked, granularity, jsEvent) {
  console.log(granularity); // "hour"
  return 'resourceTimelineDay'; // will navigate to this view...
},

// OR
navLinkClick: {
  week: 'resourceTimelineWeek',
  hour: 'resourceTimelineDay'
}

[ecnaidar]

Used slotLabelDidMount workaround for React implementation, thanks for that

slotLabelDidMount={function ({ el, date, view, level }) {
  el.addEventListener("click", function () {
    // warning, this assumes that we have 3 levels of headers
    // lvl 0 will be week in all views
    if (level === 0) {
      view.calendar.changeView("resourceTimelineWeek", date);
      view.calendar.scrollToTime({
        day: (date.getDay() + 6) % 7,
        hour: 0,
      });
    } else {
      view.calendar.changeView("resourceTimelineDay", date);
      view.calendar.scrollToTime({
        hour: 0,
      });
    }
  });
}}

Not going to lie, it kind of boggles my mind that this have been hanging on the wall for 3 years already. Especially since it is basic functionality that is broken exclusively in “premium” part of FullCalendar 🙃