Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Supprot React 17 in peer dependency declaration

See original GitHub issue

With the support added for React 18, we’ve ended up with the following peer dependency declarations:

https://github.com/fullcalendar/fullcalendar-react/blob/master/package.json#L47-L48

  "peerDependencies": {
    "react": "^16.7.0 || ^18",
    "react-dom": "^16.7.0 || ^18"
  },

This will trigger incorrect peer dependency warning for React 17, even though I don’t think it should. Do we need ^17 be included as the version also?

Issue Analytics

State:
Created a year ago
Reactions:3
Comments:8 (2 by maintainers)

Top GitHub Comments

2reactions

arshawcommented, Apr 21, 2022

I released the fix in v5.11.1. Can someone please confirm?

1reaction

tomdraczcommented, Apr 21, 2022

Can confirm 5.11.1 fixes this. Thanks @arshaw !

Top Results From Across the Web

Widen peer dependency range to include React 17 · Issue #814

@foaadnami the error is saying that there's a peer dependency conflict, because you've installed React 17 but next-auth currently requires React ...

npm Peer Dependencies - Fathom

Peer dependencies effectively declare a dependency without including the dependency in your built module. When an application includes your module, ...

Addressing the shortcomings of peer dependencies - HackMD

MUI declares React 17 as a dependency; App host declares React 18 and MUI as dependencies. When you npm install, we have a...

What does npm install --legacy-peer-deps do exactly? When ...

This error will fire whenever a module (or any of its own dependencies) lists a previous major version of React as a peerDependency...

Understanding Peer Dependencies in JavaScript

In this case, you would declare React as a peer dependency for your components, because you want the host project to have the...