Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

docker buildx command always fails in install check on Windows

See original GitHub issue

The subprocess.call overrides all environment variables instead of updating them to add the DOCKER_CLI_EXPERIMENTAL variable. This has the effect of the docker buildx binary being downloaded every time a build step is run.

https://github.com/gabrieldemarmiesse/python-on-whales/blob/2f542756e15a7aa99cb2e28f4c52fdd700aac912/python_on_whales/utils.py#L179-L187

It looks like this is handled properly where this function is called, so perhaps that env dictionary should be passed in with the docker binary argument:

https://github.com/gabrieldemarmiesse/python-on-whales/blob/2f542756e15a7aa99cb2e28f4c52fdd700aac912/python_on_whales/utils.py#L106-L110

Issue Analytics

State:
Created 2 years ago
Comments:7 (5 by maintainers)

Top GitHub Comments

1reaction

gabrieldemarmiessecommented, May 27, 2021

I’m glad it worked. I usually work on python-on-whales the thursday afternoon 😃 that’s why it was fast

1reaction

gabrieldemarmiessecommented, May 27, 2021

It will download the CLI if needed. But for buildx it seems overkill. We have tests for the downloading of dependencies, but I’m really surprised the bug you mentionned happened. #173 should fix the issue