Version 1.1.1 causes Segfault if run with pytest-mypy on large codebase

I’m using httpretty with pytest and pytest-mypy on a larger codebase (~ 404 tests, 97 times @httpretty.httprettified).

When running pytest --mypy on this code base, I am getting a Segmentation Fault after ~49% of all tests passed:

tests/tagger/test_sentence_tagger_factory.py .........                                                                                                                                                                                                                                                               [ 49%]
tests/tagger/test_tagger_factory.py ......FFatal Python error: Segmentation fault

Thread 0x000070000ed4b000 (most recent call first):
  File "/usr/local/Caskroom/miniconda/base/envs/[PROJECT]/lib/python3.8/threading.py", line 306 in wait
  File "/usr/local/Caskroom/miniconda/base/envs/[PROJECT]/lib/python3.8/threading.py", line 558 in wait
  File "/usr/local/Caskroom/miniconda/base/envs/[PROJECT]/lib/python3.8/site-packages/tqdm/_monitor.py", line 60 in run
  File "/usr/local/Caskroom/miniconda/base/envs/[PROJECT]/lib/python3.8/threading.py", line 932 in _bootstrap_inner
  File "/usr/local/Caskroom/miniconda/base/envs/[PROJECT]/lib/python3.8/threading.py", line 890 in _bootstrap

Current thread 0x000000011cd9edc0 (most recent call first):
  File "/usr/local/Caskroom/miniconda/base/envs/[PROJECT]/lib/python3.8/site-packages/httpretty/core.py", line 385 in __getattr__
  File "/usr/local/Caskroom/miniconda/base/envs/[PROJECT]/lib/python3.8/site-packages/httpretty/core.py", line 385 in __getattr__
[…line repeats 76 times in total…]
  File "/usr/local/Caskroom/miniconda/base/envs/[PROJECT]/lib/python3.8/site-packages/httpretty/core.py", line 385 in __getattr__
  ...
Segmentation fault: 11

With version 1.1.0, everything is fine.

Looking into the changes, and finding that said line 385 in core.py is

    def __getattr__(self, name):
        return getattr(self.file, name)

,

I tried undoing this change https://github.com/gabrielfalcao/HTTPretty/compare/1.1.0...1.1.1#diff-326a996e75c88c9fc8dabbfdca5029c2a409fac6a2dd9b7dffa9f3726bce7c55L367,

i.e. changed it back to

    def close(self):
        self.socket.close()
        self.file.close()

and lo, the segfault no longer happens; all tests pass.

[gleusch]

Awesome! Thank you for writing and maintaining such an extremely useful tool!

[gabrielfalcao]

Thanks for the report @gleusch I’ll get this fixed for the next release. Will keep you posted.