Imports without semicolons not treated as imports

Originally reported here: https://github.com/Galooshi/atom-import-js/issues/8

I’m moving the issue to the main project as it affects all clients.

Given this content

import AppView from './AppView'

const Test = AppView;

If you import AppView, you end up with duplicate import lines. One with semicolon (added by import-js) and one without (the original).

import AppView from './AppView';

import AppView from './AppView'

const Abc = AppView;

The original bug report is for the atom plugin, but I have confirmed this bug to exist in the vim plugin as well.

[trotzig]

This is the main regex used to match imports: https://github.com/Galooshi/import-js/blob/ae73c764682d1ff9925575d0fb3969886cc6de9f/lib/ImportStatement.js#L23. Though there’s a pre-processing step that assumes semicolons higher up in the hierarchy: https://github.com/Galooshi/import-js/blob/ae73c764682d1ff9925575d0fb3969886cc6de9f/lib/findCurrentImports.js#L51

However, I’m about to kill both of those regexes in favor of a real parser. That work is ongoing in https://github.com/Galooshi/import-js/tree/better-parsing. I can’t promise anything, but I’m hoping to release that in a 2.0 in the coming month.

[trotzig]

Of course, sorry for leaving you in the dark here.

With 2.0, import statements without semicolons at the end are already recognized. The issue that you can solve with importStatementFormatter is that import-js will automatically add the semicolon when it constructs new import statements. You should be able to use something like

// .importjs.js
module.exports = {
  importStatementFormatter: function({ importStatement }) {
    return importStatement.replace(/;$/, '');
  },
}