question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Integrate hspec in Gammapy

See original GitHub issue

The hspec code was added in gammapy.hspec In #264 . There’s a lot of work to do to properly integrate this in Sherpa directly or in gammapy.spectrum. Here’s an incomplete list:

  • Install Sherpa on travis-ci so that it becomes possible to test this
  • Make the command line gammapy-sherpa-hspec tool work again. -> this was replaced by two gammapy-spectrum-* command line tools.
  • Add a basic test that runs an example analysis.
  • Expose the EBL absorption code as separate classes or functions, download the files from here.
  • Make a proposal how to refactor this code, i.e. which functions / classes we want and where they should go (gammapy.spectrum, naima, Sherpa directly)
  • Re-factor piece by piece (this can partly be done just by improving the code in gammapy.hspec, e.g. using the Sherpa class-based API instead of the procedural API to avoid side effects via the global session object.

cc @registerrier @ignasi-reichardt @kingj90 @zblz

Issue Analytics

  • State:closed
  • Created 8 years ago
  • Comments:10 (10 by maintainers)

github_iconTop GitHub Comments

1reaction
cdeilcommented, Jun 6, 2016

@joleroi @registerrier - I’m assigning this issue to you and to the PyGamma1 milestone, i.e. let’s try and finish this up this week.

Please also have a look at https://github.com/zblz/naima/pull/119.

At the moment Naima is more advanced for spectra. Probably the EBL absorption code should be contributed there and then we import stuff from Naima where useful in Gammapy?

0reactions
cdeilcommented, Jul 7, 2016

gammapy/hspec was removed in #593. I’m closing this issue now.

Please open new issues to discuss e.g. EBL absorption or other related topics (and reference the discussion from this issue if you like).

Read more comments on GitHub >

github_iconTop Results From Across the Web

0.4 (Apr 20, 2016) — gammapy vX.Y.Z
Continuous integration testing for Windows on Appveyor added ... [#359] Add 1D spectrum analysis tool based on gammapy.hspec (Johannes King).
Read more >
Fix and test spectrum integral flux methods · Issue #62 · gammapy ...
I'm closing this very old issue, it doesn't have concrete action items and thus isn't useful. Spectrum integral flux computation is by now...
Read more >
gammapy-icrc2015-poster.pdf - CERN Indico
We use travis- ci for continuous integration and readthedocs for docs hosting. Gammapy builds on the scientific Python stack (Numpy, Scipy, scikit-.
Read more >
Gammapy – A Python package for γ-ray astronomy - arXiv
as main dependencies and integrate other packages as optional dependencies ... gammapy.hspec – Interface to spectral fitting with Sherpa.
Read more >
Data formats for gamma-ray astronomy
Gammapy uses Astropy time, with custom utility functions for FITS I/O to ... HISTORY Integrated flux (m^-2 s^-1) over all sky and energies:....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found