Direct dependency to React?

Hi, why did you added React and ReactDOM as a dependency to BackstopJS? Since that point I can’t use BackstopJS anymore because my project depends on React 16.1. and BackstopJS relies on React 15. When I run my tests with Jest they crash because of different versions of React. With BackstopJS 3.0.39 everything worked fine in the past.

[screendriver]

Hi @mantovanig,

ok, cool. But why do you have a dependency to React in general? If you made it as a peerDependency you are assuming / forcing the consuming project to use React. What if you want to use BackstopJS but don’t have nothing to do with React? For example if your project uses Angular or Vue. These projects are now forced to install React just for BackstopJS? 🤔

[visionmonster]

I think you would want all of the react / webpack code as a devDependencies sections. I think this would hold for any dependency that only applies to generating the compare/output code.

from the npm docs: https://docs.npmjs.com/files/package.json#devdependencies

If someone is planning on downloading and using your module in their program, then they probably don’t want or need to download and build the external test or documentation framework that you use In this case, it’s best to map these additional items in a devDependencies object.

It’s fine to have it as a dependency if it’s an application, but I think the trouble comes from using it as a Module especially with react.

fantastic library by the way.

I think this is the dependency structure you are looking for

https://github.com/garris/BackstopJS/pull/813