Allow waitFor() return an AsyncIterator

What problem it solves

The possibility to wait for event’s series like as example time based events

Possible Solution

I’ve considered to create a new method waitForEvents that return an AsyncIterator allowing the consumer to consume “events’ serie” using for await statement.

Pilot implementation

interface EventIterator<T> extends AsyncIterable<T>  {
    stop(): void
}

function waitForEvents<T>(  evt: Evt<T> , timeout?: number ): EventIterator<T> {

    let isStopped = false
    async function* events() {
        
        while(!isStopped) {
            try{
                const res =  await evt.waitFor( timeout )
                yield res

            } catch(error) {
                console.warn("TIMEOUT!");
                isStopped = true
            }
        }
    }

    return {
        [Symbol.asyncIterator]: () => events(),
        stop: () => isStopped = true
    }
}

Run the Proof-of-Concept

[bsorrentino]

hi @garronej

Sorry about that, I just released a patch. I do have unit test but somehow this very obvious bug slipped through.

A wise man said me once “Only men that do nothing never make mistakes” 😉

your patch works like a charm 👍

[bsorrentino]

Hi @garronej

I’ve noted that timeout seems that don’t restart to wait after receive a message. take a look here