Failed requests are logged twice when DEBUG level is enabled
See original GitHub issueI think there is a bug on ResponseProcessor in Gatling 2.2.
In previous version (2.1.7), in AsyncHandlerActor, the implementation is:
if (status == KO) { logger.warn(s"Request '$fullRequestName' failed: ${errorMessage.getOrElse("")}") if (!logger.underlying.isTraceEnabled) logger.debug(dump) } logger.trace(dump)
It’s ok: log error when DEBUG is enabled and all requests when TRACE is enabled.
But in ResponseProcessor, used in 2.2.3, the implementation is:
if (status == KO) { logger.warn(s"Request '$fullRequestName' failed: ${errorMessage.getOrElse("")}") if (!logger.underlying.isTraceEnabled) logger.debug(dump) } logger.debug(dump)
So, when DEBUG is enabled, all requests are logged…
Issue Analytics
- State:
- Created 7 years ago
- Comments:6 (3 by maintainers)
Top GitHub Comments
When you say “We intendedly raised logging level from TRACE to DEBUG.”, it’s about the second logger? In this case, we can no longer get only failed requests?
@davoustp There’s no plan for new public releases for 2.2.x atm, only if some critical bug fixes get contributed by the community. We’ll have private ones for our FrontLine customers though.