Simple gatsby-plugin-canonical-urls Protocol Bug

Description

The gatsby-plugin-canonical-urls plugin adds a rel=canonical <link> tag to the head of each HTML page.

Here is an example of code added to the head of the html document:

<link rel="canonical" href="https://www.abc.com" data-baseprotocol="https:" data-basehost="www.abc.com">

The potential problem is with the protocol. It states the protocol is “https:”. But shouldn’t it be “https” without the colon?

How to Reproduce

1. Start with the Gatsby Starter Default.
2. Install the gatsby-plugin-canonical-urls plugin.
3. Run “gatsby develop”
4. Open “localhost:8000” in Google Chrome.
5. Open the developer tools (click F12).
6. Select “Elements”
7. Expand the “head” section.
8. Look for the rel=canonical <link> tag.
9. Find the property data-baseprotocol. It should be equal to “https” not “https:”

Solution

Open the gatsby-srr.js file. And modify line 29 to remove the colon. Here is what line 29 should look like:

data-baseprotocol={parsed.protocol.slice(0, -1)}

[LekoArts]

Hi!

Sorry to hear you’re running into an issue. To help us best begin debugging the underlying cause, it is incredibly helpful if you’re able to create a minimal reproduction. This is a simplified example of the issue that makes it clear and obvious what the issue is and how we can begin to debug it.

If you’re up for it, we’d very much appreciate if you could provide a minimal reproduction and we’ll be able to take another look.

Thanks for using Gatsby! 💜

[github-actions[bot]]

Hey again!

It’s been 60 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it. Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m HUMAN_EMOTION_SORRY. Please feel free to comment on this issue or create a new one if you need anything else. As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks again for being part of the Gatsby community! 💪💜