Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Version 2.24.70 Breaks How location.search Gets Updated

See original GitHub issue

Description

Starting with version 2.24.70 my website’s search field stopped working.

Steps to reproduce

Checkout the minimal reproduction
Run yarn install && yarn run develop
Open http://localhost:8000/ in the browser and try the search field. Note that it does work.
Change “<2.24.70” in package.json to “^2.24.70”
Run yarn install && yarn run develop
Open http://localhost:8000/ in the browser and try the search field. Note that it does not work.

It looks like since 2.24.70 the changes to location.search don’t cause the useEffect hook to execute.

  useEffect(() => {
    const newSearchQuery = new URLSearchParams(location.search).get(`q`) || ``
    setSearchQuery(newSearchQuery)
    if (newSearchQuery) {
      updateResults(newSearchQuery)
    }
  }, [location.search])

Expected result

The useEffect hook should run. The website should display the search results.

Actual result

It doesn’t.

Environment

  System:
    OS: macOS 10.15.6
    CPU: (8) x64 Intel(R) Core(TM) i7-8559U CPU @ 2.70GHz
    Shell: 5.0.18 - /usr/local/bin/bash
  Binaries:
    Node: 14.8.0 - ~/.nvm/versions/node/v14.8.0/bin/node
    Yarn: 1.22.10 - /usr/local/bin/yarn
    npm: 6.14.7 - ~/.nvm/versions/node/v14.8.0/bin/npm
  Languages:
    Python: 2.7.17 - /Users/asd/.pyenv/shims/python
  Browsers:
    Chrome: 86.0.4240.75
    Firefox: 81.0.1
    Safari: 14.0
  npmPackages:
    gatsby: ^2.24.70 => 2.24.72