Bug report: FromHex then MD5/SHA1 has wrong computation

Summary

When using FromHex then MD5 computation recipe, sometimes, the hash is wrong. It seems that bytes >= 0x80 have a problem with the transformation.

Example

See the following example:

The correct hash for a single 0x80 byte should be:

>>> import hashlib
>>> hashlib.md5(bytes([0x80])).hexdigest()
'8d39dd7eef115ea6975446ef4082951f'

Possible solutions

It seems that at least another online tool is failing at this: https://cryptii.com/hexadecimal/md5 Note that the result for SHA1 is also wrong. However, the new version https://v4.cryptii.com/enigma outputs the correct result.

[nf404]

This is because update accept message as utf-8 string. U need to use updateFromArray for binary data.

var hash = CryptoApi.hasher('md5'); hash.update('\x80'); hash.finalize().stringify('hex')
// result: "602a4f1ee0d3c4da4fe18df6708ba8e0"

var hash = CryptoApi.hasher('md5'); hash.updateFromArray([0x80]); hash.finalize().stringify('hex')
// result: "8d39dd7eef115ea6975446ef4082951f"

[n1474335]

@slurdge Ah yes, I misunderstood. If the manual state update method is for strings then go ahead and leave it as a string. Make sure you run grunt test once you’ve made the changes in case some of the hashing tests break. They shouldn’t as I generated the expected hashes using Python and some other online sources, however those other sources might also be wrong in the same way.