Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Migrate from JSON.jl to JSON3.jl

See original GitHub issue

@essenciary After you have nicely moved all JSON code in Genie to JSON3, we could think about doing the same for Stipple. Here are my 2 cents to it; define a JSONText equivalent in JSON3.

using JSON3, StructTypes

struct JSONText
    s::String
end

@inline StructTypes.StructType(::Type{JSONText}) = JSON3.RawType()
@inline StructTypes.construct(::Type{JSONText}, x::JSON3.RawValue) = JSONText(string(x))
@inline JSON3.rawbytes(x::JSONText) = x.s

All JSON.lower definitions would then need to be replaced by JSON3.rawbytes() plus the StructType definition, if I got it right.

Issue Analytics

State:
Created 2 years ago
Reactions:1
Comments:7 (3 by maintainers)

Top GitHub Comments

1reaction

hhaenselcommented, Dec 8, 2021

It seems that no packages use JSON.lower() yet, so we don’t need the above lines. They would break incremental compilation anyhow 😉 I’ll prepare a PR …

0reactions

essenciarycommented, Dec 8, 2021

Awesome! It was used for sure but we might’ve gotten rid of it. I’ll run some tests with the PR too.