Crash in ListPreference during rotation

Hello. If you rotate device 2 times with the open dialog then occurs crash:

java.lang.IllegalStateException: Failure saving state: ListPreferenceDialogFragmentCompat{9d3f3e08 #1 android.support.v7.preference.PreferenceFragment.DIALOG} has target not in fragment manager: SettingsFragment{9d3f3c08}
at android.support.v4.app.FragmentManagerImpl.saveAllState(FragmentManager.java:1935)
at android.support.v4.app.FragmentController.saveAllState(FragmentController.java:134)
at android.support.v4.app.FragmentActivity.onSaveInstanceState(FragmentActivity.java:568)
at android.support.v7.app.AppCompatActivity.onSaveInstanceState(AppCompatActivity.java:511)
at android.app.Activity.performSaveInstanceState(Activity.java:1153)
at android.app.Instrumentation.callActivityOnSaveInstanceState(Instrumentation.java:1223)
at android.app.ActivityThread.handleRelaunchActivity(ActivityThread.java:3712)
at android.app.ActivityThread.access$900(ActivityThread.java:135)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1202)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:136)
at android.app.ActivityThread.main(ActivityThread.java:5017)
at java.lang.reflect.Method.invokeNative(Native Method)
at java.lang.reflect.Method.invoke(Method.java:515)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:779)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:595)
at dalvik.system.NativeStart.main(Native Method)

[Gericop]

I see the problem and is not related to this library nor any other libs. The problem is the way you create / use your StorageSettingsFragment. You probably use the fragment adder in a similar manner in your Activity:

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);

    // [...]

    StorageSettingsFragment fragment = StorageSettingsFragment.newInstance();

    getSupportFragmentManager().beginTransaction()
                .replace(R.id.fragment_container, fragment).commit()
}

The problem with this is that when you rotate your phone, a new fragment gets created every time which replaces the old one. This won’t crash until you have a child fragment of that fragment (in this case it’s ListPreferenceDialogFragmentCompat) which has the old fragment as a target set.

To solve the problem, you just have to check whether it’s the first time onCreate(...) is called. It’s pretty simple with the received argument of savedInstanceState. If it’s null, it’s the first time. Nice, huh? In your case, the actual fix looks like this:

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);

    // [...]

    if (savedInstanceState == null) {
        StorageSettingsFragment fragment = StorageSettingsFragment.newInstance();

        getSupportFragmentManager().beginTransaction()
                .replace(R.id.fragment_container, fragment).commit()
    }
}

[proninyaroslav]

Thanks for the tip. I’ll try to do either.